This is such a weird point, and it's why sometimes it counts and sometimes it doesn't. The PA Constitution is weirdly worded:

>§ 3. Religious freedom.
>
>All men have a natural and indefeasible right to worship Almighty God according to the dictates of their own consciences; no man can of right be compelled to attend, erect or support any place of worship, or to maintain any ministry against his consent; no human authority can, in any case whatever, control or interfere with the rights of conscience, and no preference shall ever be given by law to any religious establishments or modes of worship.
>
>§ 4. Religion.
>
>No person who acknowledges the being of a God and a future state of rewards and punishments shall, on account of his religious sentiments, be disqualified to hold any office or place of trust or profit under this Commonwealth.

IIRC, this was put in place so that no-one could be disqualified because of the practice of religion and served to make sure that you were not barred from office for practicing and flavor of worship. But it certainly doesn't proscribe atheists from holding office.